DM-23090: Add LATISS commissioning filters #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The args should be returned without running the command, and the command should not call sys.exit itself in main()
Implements RFC-650. Only one line needed to be changed.
| lambdaEff=364.59, lambdaMin=324.0, lambdaMax=395.0), | ||
| FilterDefinition(physical_filter="g", | ||
| FilterDefinition(physical_filter="blank_bk7_wg05", | ||
| lambdaEff=0.0), |
There was a problem hiding this comment.
if lambdaEff=0.0 are lambdaMin and lambdaMax not needed?
There was a problem hiding this comment.
That seems to be the implication from looking elsewhere.
| @@ -144,8 +144,8 @@ def __init__(self, inputPolicy=None, **kwargs): | |||
| LsstCamMapper._nbit_patch = 5 | |||
| LsstCamMapper._nbit_filter = 6 | |||
|
|
|||
| LsstCamMapper._nbit_id = 64 - (LsstCamMapper._nbit_tract + 2*LsstCamMapper._nbit_patch + | |||
| LsstCamMapper._nbit_filter) | |||
| LsstCamMapper._nbit_id = 64 - (LsstCamMapper._nbit_tract + 2*LsstCamMapper._nbit_patch | |||
There was a problem hiding this comment.
This is rather unclear to me what this is doing...
There is a limit on how many filters you can declare to afw?
There was a problem hiding this comment.
It's not obvious but the important thing for this pull request is that I moved the plus from the end of one line to the start of the next because of an RFC that got adopted yesterday.
There was a problem hiding this comment.
OK, please link the RFC to the ticket prior to merging.
patrickingraham
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at adding the 4 commissioning filters. I've completely replaced the previous LSST filters that were in the LATISS definition.
Also some minor additional code cleanups since I was looking.