DM-21308: Replace doApplyUberCal with doApplyExternal configs #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
Jan 23, 2020
config/compareWarpAssembleCoadd.py
Outdated
| @@ -30,4 +30,5 @@ | |||
| config.assembleStaticSkyModel.subregionSize = (10000, 200) | |||
|
|
|||
| # FUTURE Set to True if we run meas_mosaic or jointcal | |||
There was a problem hiding this comment.
Please clarify this comment refers to 2 lines below, not just 1.
mrawls
reviewed
Jan 23, 2020
config/makeCoaddTempExp.py
Outdated
| @@ -31,7 +31,8 @@ | |||
| config.modelPsf.defaultFwhm = 7.7 | |||
|
|
|||
| # FUTURE: Set to True when we decide to run jointcal | |||
There was a problem hiding this comment.
Same as above, this comment applies to 2 configs and not just 1.
mrawls
approved these changes
Jan 23, 2020
erykoff
force-pushed
the
tickets/DM-21308
branch
from
aeb92d7
to
75db9f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.