DM-23171: Add exposure_group calculation and make visit_id use it #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposure group now read from GROUPID header if defined, else uses the exposure_id as a string. Visit has to be changed to match since things with the same exposure_group must now have matching visit id. If exposure_group is a number use it, else derive it from the group ID.
timj
force-pushed
the
tickets/DM-23171
branch
from
d59f3c8
to
9254cc4
Compare
This is ObservationInfo.exposure_group
SimonKrughoff
approved these changes
Jan 27, 2020
| tdelta = iso - TZERO_DATETIME | ||
| epoch = int(tdelta.total_seconds()) | ||
|
|
||
| # Form the integer from EPOCH + 3 DIGIT FRAC + 0-pad N |
There was a problem hiding this comment.
You don't mean addition here. It's an append. I agree it's clear from the next line.
| TZERO = Time("2015-01-01T00:00", format="isot", scale="utc") | ||
| TZERO_DATETIME = TZERO.to_datetime() | ||
|
|
||
| # Regex to use for parsing a GROUPID string |
There was a problem hiding this comment.
Maybe add an example string this is meant to match?
| visit_id = int(digest, base=16) | ||
|
|
||
| # To help with hash collision, append the string length | ||
| visit_id = int(f"{visit_id}{len(exposure_group):02d}") |
There was a problem hiding this comment.
Why truncate to two digits?
There was a problem hiding this comment.
The length comes from a FITS header value and unless we are going crazy with CONTINUE header cards 72 is the longest group ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposure group now read from GROUPID header if defined,
else uses the exposure_id as a string. Visit has to be
changed to match since things with the same exposure_group
must now have matching visit id.
If exposure_group is a number use it, else derive it
from the group ID.
Depends on lsst/astro_metadata_translator#35