DM-23222: More LATISS header fixes #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this date IMGTYPE=OBJECT means on sky
FITS will also default to ICRS if the value was not defined.
patrickingraham
approved these changes
Jan 31, 2020
| return None | ||
|
|
||
| # ALTAZ always relevant unless bias or dark | ||
| if self.to_observation_type() in ("bias", "dark"): |
There was a problem hiding this comment.
We take flats with the shutter open at fixed AZEL so we want the translator to report that AZEL. Isn't that right?
There was a problem hiding this comment.
It certainly can... but it could with bias and dark as well...
I think it doesn't matter really. It'll never get used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.