DM-23281: Include GRATING in filter definition #165
Conversation
timj
force-pushed
the
tickets/DM-23281
branch
2 times, most recently
from
be8d218
to
8c812eb
Compare
|
You refer to test failures but those are not reproducible for me (or Jenkins) and so I don't really understand them. |
timj
force-pushed
the
tickets/DM-23281
branch
from
8c812eb
to
7ba0d5c
Compare
|
I take that back. It's now failing the test for me! No idea what changed there but at least I can fix it. |
timj
force-pushed
the
tickets/DM-23281
branch
5 times, most recently
from
67cb97f
to
1ac5862
Compare
| @@ -73,4 +76,31 @@ | |||
| lambdaEff=0.0), | |||
| FilterDefinition(physical_filter="EMPTY", | |||
There was a problem hiding this comment.
Is there a reason that EMPTY isn't just an alias for NONE and OPEN. They're physically the same, right? (I realise this is kind of not in scope as this was pre-existing, but given we're redefining some meanings here/making new categories, it's also somewhat relevant). If there's a reason I've not thought of to keep them separate just ignore me though.
There was a problem hiding this comment.
I'm not sure where we're going long term with the AuxTel filters, but in the current configuration one filter slot has a piece of plain glass with no filtering capability, and one slot is completely empty. So we need a way to differentiate those two.
There was a problem hiding this comment.
Plain glass is considered to be none of EMPTY, NONE or OPEN. They're listed (so far) as blank_bk7_wg05 or similar, with the string after blank_ specifying the glass type so that they can be differentiated if we choose to, and are, at present, treated as normal filters for the sake of both data management and processing. I think that's the right thing to do for all eventualities, but I'm open to persuasion, as always!
There was a problem hiding this comment.
I can't use filter aliases because butler registries don't use the aliases (only afw uses them when you ask for a filter by the "wrong" name).
|
See what you think about the one new comment I had. Other than that, it's working great, so just rebase and merge whenever you like. |
|
(except I just tried rebasing and running the tests again, and now get one test failure, so the above is obviously modulo that 😕) |
|
Yes, will fix. I merged some other tickets that added new test files that will need to have the grating added. |
There is less chance of ~ being in the filter/grating name than +
timj
force-pushed
the
tickets/DM-23281
branch
from
f2e7d7b
to
515cc4c
Compare
No description provided.