Template and config updates for defects #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Feb 13, 2020
| @@ -610,4 +610,4 @@ datasets: | |||
| storage: FitsStorage | |||
| tables: | |||
| - raw | |||
| template: calibrations/defects/defects-det%(detector)03d.fits | |||
| template: calibrations/SomethingHasToGoHereButThisIsOverwrittenLater%(detector)03d.extension | |||
There was a problem hiding this comment.
I would prefer a different string, but agree that this makes it easy to search in case something goes wrong.
There was a problem hiding this comment.
Yeah, it's gross. Talking to KT about this and other things soon. Won't merge till that's happened at least. (Mostly made it like that to force us to discuss this anyway!)
mfisherlevine
force-pushed
the
tickets/DM-23448
branch
from
06ee20f
to
4d93499
Compare
mfisherlevine
force-pushed
the
tickets/DM-23448
branch
from
4d93499
to
c633f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates so the defect finding task actually works, and is compatible with ingest.