DM-23589: Add 3 new filters to LATISS #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
approved these changes
Feb 21, 2020
| @@ -142,7 +142,7 @@ def __init__(self, inputPolicy=None, **kwargs): | |||
|
|
|||
| LsstCamMapper._nbit_tract = 16 | |||
| LsstCamMapper._nbit_patch = 5 | |||
| LsstCamMapper._nbit_filter = 6 | |||
| LsstCamMapper._nbit_filter = 7 | |||
There was a problem hiding this comment.
This give us 128. Is this one per filter as defined above, or one per combination? If the former, 128 should be enough. If the latter, I suspect this should change to at least 8.
Also, does changing this mean that things need reingesting as numbers change, or no?
There was a problem hiding this comment.
Looks like this is mainly used for source IDs from coadds.
There was a problem hiding this comment.
Oh and remember that every time we add a filter we add that filter and that filter with each grating combination. I added three filters here so that's an extra 18 filters. (there are 5 gratings defined including the empties and none and ???).
This changes all LSSTCam mappers but given the timeline for Gen2 deprecation there doesn't seem to be much point in worrying about this.
We can not use an abstract filter name for BG40 since afw does not allow two filters to share an abstract name.
timj
force-pushed
the
tickets/DM-23589
branch
from
1da6757
to
5c9e729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.