DM-24495: Switch to using __file__ to reference other configs. #201
Conversation
config/sky.py
Outdated
| @@ -22,13 +22,12 @@ | |||
|
|
|||
| import os.path | |||
|
|
|||
| from lsst.utils import getPackageDir | |||
| # The following will have to be uncommented and adapted when the | |||
| # X-talk correction will be active | |||
| #from lsst.obs.lsst.isr import SubaruIsrTask | |||
| #config.isr.retarget(SubaruIsrTask) | |||
| #config.isr.load(os.path.join(getPackageDir("obs_lsst"), "config", "isr.py")) | |||
There was a problem hiding this comment.
Should this be updated as well? I don't know the logic behind this entire commented block (which seems thoroughly out of date), but if getPackageDir will no longer be imported, this line will fail if uncommented.
There was a problem hiding this comment.
I wasn't sure what to do with it either. obs_subaru/config/hsc/sky.py does indeed load its own ISR config override, but I don't know enough about what this task does to know why it might be okay that we don't do that right now for obs_lsst - I suspect the answer is that we never run this task on any LSST camera, and hence this whole file is a waste of time. But I don't know.
I suppose the path of least resistance is just to switch to using __file__ in the comment, too.
There was a problem hiding this comment.
I looked at this again and realized that this config already loads obs_lsst's custom ISR, so I'm pretty confident the entire comment is defunct. I'm just removing it.
The ISR configuration overrides are already loaded later in the config, so we don't need a TODO reminding us to do that in the future.
TallJimbo
force-pushed
the
tickets/DM-24495
branch
from
2402303
to
dba29a9
Compare
See https://community.lsst.org/t/pex-config-configs-now-know-where-they-are/4023.