Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-24924: Update telescope names #210

Merged
merged 1 commit into from May 14, 2020
Merged

DM-24924: Update telescope names #210

merged 1 commit into from May 14, 2020

Conversation

timj
Copy link
Member

@timj timj commented May 14, 2020

  • Simonyi Survey Telescope for LSSTCam, ComCam, ImSim, PhoSim
  • Rubin Auxiliary Telescope for LATISS
  • None for test stands

@timj timj requested a review from mareuter May 14, 2020 19:49
Copy link
Member

@mareuter mareuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Otherwise it looks good.

@@ -106,7 +106,7 @@ class LatissTranslator(LsstBaseTranslator):
# LATISS is not yet attached to a telescope so many translations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since LATISS is now on a telescope, I think this comment should either go away or be modified.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminds me that we have to add support to translator for weather data at some point.

- Simonyi Survey Telescope for LSSTCam, ComCam, ImSim, PhoSim
- Rubin Auxiliary Telescope for LATISS
- None for test stands
@timj timj merged commit 3ce2d20 into master May 14, 2020
@timj timj deleted the tickets/DM-24924 branch May 14, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants