Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26205: Fix obs_lsst to handle corner raft data #240

Merged
merged 4 commits into from Aug 4, 2020
Merged

DM-26205: Fix obs_lsst to handle corner raft data #240

merged 4 commits into from Aug 4, 2020

Conversation

RobertLuptonTheGood
Copy link
Member

Second attempt

@timj timj changed the title Tickets/dm 26205 Fix obs_lsst to handle corner raft data DM-26205: Fix obs_lsst to handle corner raft data Aug 3, 2020
SimonKrughoff
SimonKrughoff approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a minor comment about how to check whether you are looking at a wavefront sensor or not.

python/lsst/obs/lsst/lsstCamMapper.py Outdated Show resolved Hide resolved
@RobertLuptonTheGood RobertLuptonTheGood force-pushed the tickets/DM-26205 branch 2 times, most recently from bb508f1 to b0c4a8a Compare August 4, 2020 05:37
@RobertLuptonTheGood
Improved error messages
42ea073
@RobertLuptonTheGood
The wave front chips have only 8 amplifiers
125efd8
@RobertLuptonTheGood
LCA-13381 changed the WF chips to be the top of an ITL CCD
bc9db37 
N.b. they were previously the bottom of an ITL CCD, and this
change has ripple effects on the geometry.

Make CCD_ITL_G/WF reuse CCD_ITL, in particular, don't override
the base amp assembly as there is no longer any need
@RobertLuptonTheGood
Warn if the EXTNAME is wrong
5ae5fec
@RobertLuptonTheGood RobertLuptonTheGood merged commit 0b1c522 into master Aug 4, 2020
@timj timj deleted the tickets/DM-26205 branch May 12, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teweitsai teweitsai teweitsai left review comments

@SimonKrughoff SimonKrughoff SimonKrughoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RobertLuptonTheGood @SimonKrughoff @teweitsai