DM-26550: Add support for ObservationInfo.observation_reason #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertLuptonTheGood
approved these changes
Sep 3, 2020
| @@ -24,8 +24,7 @@ | |||
|
|
|||
| config.parse.retarget(LatissParseTask) | |||
|
|
|||
| del config.parse.translation['testType'] | |||
|
|
|||
| del config.parse.translators['testType'] | |||
There was a problem hiding this comment.
Do we need this white-space only change?
There was a problem hiding this comment.
It's not a whitespace only change.
|
I don't think I can do anything other than believe the value of the TESTTYPE header can I? Garbage in and garbage out. If you think that TESTTYPE=bias could be translated to something else then I'm happy to tweak the translation here. |
|
Tim explained that the test code was using real |
timj
force-pushed
the
tickets/DM-26550
branch
from
0a49f2b
to
8c47d6f
Compare
This allows TESTTYPE handling to be unified.
timj
force-pushed
the
tickets/DM-26550
branch
from
8c47d6f
to
0b3b552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows TESTTYPE handling to be unified.
Requires lsst/astro_metadata_translator#40