Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-21706: Add filter definitions to support BOT #251

Merged
merged 15 commits into from
Sep 16, 2020
Merged

DM-21706: Add filter definitions to support BOT #251

merged 15 commits into from
Sep 16, 2020

Commits on Sep 16, 2020

  1. Add filter definitions for BOT data

    @mfisherlevine @RobertLuptonTheGood
    mfisherlevine authored and RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    a3520d6 View commit details
    Browse the repository at this point in the history

  2. Add updated filter information

    @rhiannonlynne @RobertLuptonTheGood
    rhiannonlynne authored and RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    ddf2802 View commit details
    Browse the repository at this point in the history

  3. Initial version of BOT filters

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    70a198d View commit details
    Browse the repository at this point in the history

  4. Finished BOT filters. Renamed NONE -> UNKNOWN

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    d2284c3 View commit details
    Browse the repository at this point in the history

  5. Ran tests/bin/reingest.sh with new filter names

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    ca87746 View commit details
    Browse the repository at this point in the history

  6. Make tests pass with new filter names

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    9b23b04 View commit details
    Browse the repository at this point in the history

  7. Recover from failed reingestion

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    5423e32 View commit details
    Browse the repository at this point in the history

  8. Allow list of instruments on command line

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    29b2c5a View commit details
    Browse the repository at this point in the history

  9. Use UNKNOWN not ??? for unknown LATISS filters

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    392da61 View commit details
    Browse the repository at this point in the history

  10. Ran tests/bin/reingest.sh

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    a61a7e8 View commit details
    Browse the repository at this point in the history

  11. Get LATISS tests working with UNKNOWN

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    7d448af View commit details
    Browse the repository at this point in the history

  12. Empty file that got added at some point

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    a1e7b40 View commit details
    Browse the repository at this point in the history

  13. Addressed review comments

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    c54cc3c View commit details
    Browse the repository at this point in the history

  14. Added tests for comCam and LSSTCam

    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    1deeada View commit details
    Browse the repository at this point in the history

  15. Add more ND filters and use base part of filter in coaddExposureId 

    With all the ND filters in the second BOT filter wheel we have more than 128 filters, so would need an extra bit in nbit_filter. Instead, we only use the "base" of the filter name (discarding anything after the ~) when calculating coaddExposureId.  This is OK because we won't ever be coadding data of this type;  additionally we assert that the ID of any filter that appears in a coaddExposureId fits in the allocated bits, and arrange that the real LSST filters satisfy this condition.
    @RobertLuptonTheGood
    RobertLuptonTheGood committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    65dd889 View commit details
    Browse the repository at this point in the history