Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26811: Rename LSST-ImSim to LSSTCam-imSim (and phosim now LSSTCam-PhoSim) #252

Merged
merged 2 commits into from Sep 21, 2020
Merged

DM-26811: Rename LSST-ImSim to LSSTCam-imSim (and phosim now LSSTCam-PhoSim) #252

merged 2 commits into from Sep 21, 2020

Conversation

timj
Copy link
Member

@timj timj commented Sep 18, 2020

This makes it clear that these are simulations of LSSTCam and also follows a request from @cwwalter to use "imSim" and not "ImSim".

cwwalter
cwwalter approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@cwwalter cwwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I checked against the file list for completeness and looked for any missed substitutions. Thanks Tim.

@timj timj merged commit b6ea654 into master Sep 21, 2020
@timj timj deleted the tickets/DM-26811 branch September 21, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwwalter cwwalter cwwalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @cwwalter