DM-26943: Use AIRMASS or AMSTART headers for imsim if they exist #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-26943
branch
from
b1505d8
to
88897bb
Compare
ehneilsen
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
I would expect the _erfa import to be at the head of the file with the rest of the imports. Is there a reason it is embedded in the code?
Also, it looks like astropy._erfa has now been deprecated by the astropy team in favor of using a separate standalone pyerfa package. It doesn't look like this is available yet in the version of astropy used here, though.
| dec = Angle(self._header["DECTEL"], unit=u.deg) | ||
|
|
||
| # Use erfa directly | ||
| import astropy._erfa as erfa |
There was a problem hiding this comment.
The import should maybe be moved to the top of the file?
|
Thanks. Yes, I'll try to support pyerfa (I found out about that from the astropy slack over the weekend). I'll also probably move the core hour angle to azel code into astro_metadata_translator since it's generic. |
timj
force-pushed
the
tickets/DM-26943
branch
from
88897bb
to
b2f4c50
Compare
timj
force-pushed
the
tickets/DM-26943
branch
from
b2f4c50
to
f06715f
Compare
This is faster and more reliable than trying to derive it from the RA/Dec in the future (which also requires assumptions on leap seconds).
timj
force-pushed
the
tickets/DM-26943
branch
from
f06715f
to
d46bbd0
Compare
ehneilsen
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.