DM-24355: Make Instrument registration idempotent. #258
Conversation
| } | ||
| ) | ||
| for detector in self.getCamera(): | ||
| registry.syncDimensionData("detector", self.extractDetectorRecord(detector)) |
There was a problem hiding this comment.
Did the bulk insert version disappear or something? Previously it built all the records and did one insert, here it does a separate sync for each detector.
There was a problem hiding this comment.
Correct. syncDimensionData doesn't do bulk. It probably could be made to now with enough effort, but that's a bigger change than I wanted to make on this ticket, and I think for an operation as rare as instrument registration ought to be, a few hundred single-row insert operations is not a big problem. I figured being able to add new detectors (and check for consistency with all existing ones) was more valuable than performance in this context.
A no-op sync is not free, though, and I've tried to document that wherever I could. If people throw calls to Instrument.register and the like everywhere (especially TestCase.setUp) we will regret it.
TallJimbo
force-pushed
the
tickets/DM-24355
branch
from
3864490
to
ea8d6ce
Compare
No description provided.