Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-27158: constructDark.py fails on LSSTCam with 'Too many CR pixels' #262

Merged
merged 1 commit into from Oct 23, 2020

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Oct 22, 2020

Update R41_S11_C14's readnoise to 25.0, based on BOT data.

This update allows the regular constructDark.py processing to succeed
on this amplifier, as the elevated read noise prevents the cosmic ray
rejection from identifying everything as a cosmic ray.

This update allows the regular constructDark.py processing to succeed
on this amplifier, as the elevated read noise prevents the cosmic ray
rejection from identifying everything as a cosmic ray.
Copy link
Contributor

@plazas plazas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is trivial, and it looks good if it helps {{constructDark}}. And I also see that you outline, in the Jira ticket, an iterative process that is self-contained within the DM code to deal with this via {{doEmpiricalNoise}}. The more general question is, given that we have gain, full-well capacity at saturation, and noise values from the latest BOT runs (both using eoTtest and DM tools), can't we just update all these YAML files with those more realistic values? Maybe this is a more general discussion.

@czwa czwa merged commit 47c096f into master Oct 23, 2020
@timj timj deleted the tickets/DM-27158 branch May 12, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants