DM-28158: Remove assertion on times that are no longer top far in the future. #279
Conversation
There was a problem hiding this comment.
Please fix the typo in the commit message ("top" -> "too"?), otherwise this looks fine.
I'm a little worried this might trip us up again in the future, when the ImSim data might instead be too far in the past. Could you instead catch this specific type of error with a try/except block, or would that defeat the test?
| self.assertObservationInfoFromYaml(filename, dir=self.datadir, **expected) | ||
| else: | ||
| self.assertObservationInfoFromYaml(filename, dir=self.datadir, **expected) | ||
| self.assertObservationInfoFromYaml(filename, dir=self.datadir, **expected) |
There was a problem hiding this comment.
The only comment is that this test was mainly there to hide the warning from the test output so that people don't get confused when they run pytest and see some unexpected warnings turning up. I assume that is not a problem here because now we've hit a time where imsim will never trigger more warnings.
I don't think "too far in the past" is a thing; I think the logic astropy is worried about projecting into the future is based on some kind of table for which historical data is not a problem (at least in the modern era). |
TallJimbo
force-pushed
the
tickets/DM-28158
branch
from
b3975bf
to
a73dc90
Compare
No description provided.