DM-27170: Deprecate and phase out afw::image::Filter #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
reviewed
Jan 5, 2021
|
Answering your question re: "unknown" in the tests: that's what the filters in those files are called. I'm assuming this is very early data for those cameras and they came from before various headers were standardized. |
Remove logic for filter lookup failures that will no longer trigger: this depends on the old Filter singleton which no longer exists.
The filter name "unknown" in these cases comes from the files themselves.
parejkoj
force-pushed
the
tickets/DM-27170
branch
from
761942f
to
8871c69
Compare
kfindeisen
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.