Tickets/dm 28553: Update the gain, readNoise, and saturation levels based on EOTest #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I didn't specify any new values, so this just fixes up the formatting to be consistent. The biggest changes are the number of significant digits in gain/readNoise/saturation and that I split the three values onto different lines to isolate changes in future commits.
recommended by Jim Chiang
Specifically, ran
updateFromEOTest.py --gain curated_amp_gains_2020-09-16.json \
--read read_noise_12794.json \
--satur ptc_turnoff_12794.json
ktlim
reviewed
Feb 5, 2021
KT pointed out that my initial hack was wrong. Fixed code and reran the command to regen the yaml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.