DM-28459: Standardize LSSTCam and LATISS filter band derivations #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the band inheritst the full physical_filter~grating default.
none is an alias for empty. If we have any data files that say "none" for the grating we should use the metadata translator to correct them to empty.
Without specifying a band the band becomes the physical_filter~grating string and multiplies rapidly. An alternative is to use the non-band physical filter name as the band without using the grating value if the band is missing.
so change the special blank filter to white band
Stop trying to keep track of aliases since those are specifically a feature for deprecated afwFilter. Simplify band assignments for ND to use a generic ~nd band modifier.
diffuser was only used in lab testing without a grating
mfisherlevine
approved these changes
Feb 10, 2021
Comment on lines
+236
to
+239
| # The diffuser "filter" was never used with gratings | ||
| # so skip it | ||
| if filter.physical_filter == "diffuser": | ||
| continue |
There was a problem hiding this comment.
I think this is likely fine, I just worry that just because that wasn't happened to date, that doesn't mean it never will in future. But I think this is probably fine for now, give we're really trying to keep the numbers down.
There was a problem hiding this comment.
If new diffuser data turns up we can sort it out at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.