DM-24638: Add DRP pipeline specification #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
force-pushed
the
tickets/DM-24638
branch
from
58cc32a
to
2fd405b
Compare
parejkoj
reviewed
Feb 18, 2021
| @@ -0,0 +1,5 @@ | |||
| description: DRP pipeline applicable to all cameras in obs_lsst | |||
| imports: | |||
| - location: $PIPE_TASKS_DIR/pipelines/DRP.yaml | |||
There was a problem hiding this comment.
Out of curiosity, what is specific to LSST in this? Couldn't it live in a non-instrument package?
There was a problem hiding this comment.
See convo on obs_subaru. Source table only works on obs_lsst/imsim and obs_subaru until I do DM-28862. Instead of putting the sourceTable tasks in the obs_lsst/imsim and obs_subaru DRP pipelines, @natelust preferred me to add it to pipe_tasks and exclude it everywhere but obs_lsst/imsim and obs_subaru. I don't care. I just want to merge the gen3-fied source table tasks.
yalsayyad
force-pushed
the
tickets/DM-24638
branch
from
2fd405b
to
01e6670
Compare
natelust
approved these changes
Feb 22, 2021
and add config override files for tasks with changed DefaultNames in Gen3
yalsayyad
force-pushed
the
tickets/DM-24638
branch
from
01e6670
to
239467c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add config override files for tasks with
changed DefaultNames in Gen3