Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-29187: Do not fix RASTART header for LATISS after 2021-02-12 #295

Merged
merged 2 commits into from Mar 18, 2021

Conversation

timj
Copy link
Member

@timj timj commented Mar 12, 2021

No description provided.

Copy link
Member

@RobertLuptonTheGood RobertLuptonTheGood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I'm not qualified to comment on when the time was correct (but put the general question of notifying people of this sort of change on the next CAP meeting agenda)

@timj
Copy link
Member Author

timj commented Mar 16, 2021

Who does know when it was fixed? I probably shouldn't merge it until we know. @menanteau do you know when the 37s offset was fixed in RASTART or is that more of a @tribeiro question?

@menanteau
Copy link

@timj I think this was related to the timestamp from Camera was sent in UTC instead of TAI. But I can be mistaken.

@timj
Copy link
Member Author

timj commented Mar 16, 2021

I imagine the question is whether anyone cares about the difference in reality. If I declare it to be correct on that date but it was in fact fixed a week later the only thing that really happens is that the WCS correction will have to do more work. If that's the case I'll merge tomorrow for the weekly if no-one else jumps in.

RobertLuptonTheGood and others added 2 commits March 18, 2021 09:51
Note that this does not address the issue referred to in DM-29187,
namely that this correction is applied multiple times.
@timj timj merged commit 0bee64f into master Mar 18, 2021
@timj timj deleted the tickets/DM-29187 branch March 18, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants