DM-30342: Add detect flags to object tables #314
Conversation
policy/imsim/Object.yaml
Outdated
| - calib_psf_used | ||
| - merge_measurement_band |
There was a problem hiding this comment.
From what I can tell, this should simply be merge_measurement. Then add a renaming rule at the bottom like ['merge_', 'Merge_']. (The band will be appended at the beginning to create, e.g., zMerge_measurement.)
There was a problem hiding this comment.
But where should it go? The comment in Object.yaml says # refFlags are columns taken without translation from the ref table, so it sounds like the band isn't passed through them. And the flags section says # flags are columns taken and exploded per-band from the meas tables, but I don't think that these columns exist in the meas tables.
There was a problem hiding this comment.
I think that I'm just going to call merge_measurement out of scope and assign that to a new ticket.
There was a problem hiding this comment.
I'm OK with calling merge_measurement out of scope for this one. But I think you will still need the renaming rule for merge_ --> Merge_?
There was a problem hiding this comment.
Yup, that change is about to be pushed.
policy/imsim/Source.yaml
Outdated
| - detect_isDeblendedSource | ||
| - detect_isDeblendedModelSource | ||
| - merge_peak_sky | ||
| - merge_measurement_band |
There was a problem hiding this comment.
See comment above. Note also that the same renaming rule proposed above is needed for merge_peak_sky, too.
yalsayyad
force-pushed
the
tickets/DM-30342
branch
from
1f7c272
to
984f4e9
Compare
yalsayyad
force-pushed
the
tickets/DM-30342
branch
from
984f4e9
to
a6ca213
Compare
No description provided.