DM-31445: Enable GAaP PSF photometry before apCorr #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doPsfPhotometry must be set to True prior to registering the plugin for aperture corrections.
erykoff
approved these changes
Aug 18, 2021
| @@ -35,6 +35,9 @@ | |||
| config.catalogCalculation.plugins.names = ["base_ClassificationExtendedness"] | |||
| config.measurement.slots.psfFlux = "base_PsfFlux" | |||
|
|
|||
| # Enable PSF photometry after PSF-Gaussianization in the `ext_gaap_GaapFlux` plugin | |||
| config.measurement.plugins["ext_gaap_GaapFlux"].doPsfPhotometry = True | |||
|
|
|||
There was a problem hiding this comment.
I'm just curious why this reordering was necessary? And if there's some missing documentation, can that be ticketed?
There was a problem hiding this comment.
I wanted this to appear before doUndeblended function call on the GAaP plugin. Basically, this has to be set to True before the getAllGaapResultNames() method is called. It may not have any effect whatsoever, but wanted to be doubly safe.
arunkannawadi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doPsfPhotometrymust be set toTrueprior to registering the plugin foraperture corrections.