Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31760: Single amp reads for obs_lsst have the wrong geometry. #345

Merged
merged 3 commits into from
Sep 15, 2021
Merged

DM-31760: Single amp reads for obs_lsst have the wrong geometry. #345

merged 3 commits into from
Sep 15, 2021

Commits on Sep 14, 2021

  1. Fix transform for single-amp reads. 

    If the detector has been modified, then any transforms need to be
relative to the new XY offset position that is calculated during that
modification.
    @czwa
    czwa committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    5d8408e View commit details
    Browse the repository at this point in the history

  2. Remove failing test. 

    After modifying the amplifier, there may be shifts between it and the
camera-derived amplifier.  As this isn't simply changing a assertTrue
to assertFalse (as the first amp in the axis that is modified will
actually have shift=0), removing the test seems the only solution.
    @czwa
    czwa committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    1e72066 View commit details
    Browse the repository at this point in the history

  3. Use on_disk_amplifier name for clarity.

    @czwa
    czwa committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    5b7e6e3 View commit details
    Browse the repository at this point in the history