DM-32129: Add a maximum mean offset threshold for SFM astrometry fit success #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-32129
branch
3 times, most recently
from
4e94ac7
to
0fb53a3
Compare
erykoff
approved these changes
Oct 14, 2021
config/imsim/calibrate.py
Outdated
| @@ -35,6 +35,8 @@ | |||
| config.photoRefObjLoader.load(os.path.join(configDir, "filterMap.py")) | |||
|
|
|||
| config.astrometry.doMagnitudeOutlierRejection = True | |||
| # Set threshold above which astrometry will be considered a failure (DM-32129) | |||
| config.astrometry.maxMeanDistanceArcsec = 0.08 | |||
There was a problem hiding this comment.
This is a scatter of ~0.4 pixels, right? That seems bad to me! But this includes the scatter in the measurement, and is thus band and s/n dependent, etc. I would still personally advocate for something closer to 0.05. We lose some few more, but these aren't especially good fits anyway, and we don't have any jointcal afterburner to improve things.
There was a problem hiding this comment.
I'm so down with 0.05! I have posted per-band distributions to the ticket (nothing too striking, I don't think).
This tolerance was conditioned on looking at the distribution of the sample of 30495 successful SFM fits of the tract 4431 processing run of PREOPS-631 (see DM-32129 for justification).
laurenam
force-pushed
the
tickets/DM-32129
branch
from
0fb53a3
to
44c0bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.