DM-31997: Apply 180 degree offset due to change in defintions #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Nov 12, 2021
| @@ -390,6 +394,10 @@ def fix_header(cls, header, instrument, obsid, filename=None): | |||
| if header[h]: | |||
| header[h] += offset | |||
|
|
|||
| if date > ROTPA_CONVENTION_180_SWITCH1 and date < ROTPA_CONVENTION_180_SWITCH2: | |||
There was a problem hiding this comment.
Can we reverse these tests please? For most of the data we take the date will be greater than SWITCH1 and the test will be true but for only a small fraction of date will the second test be true. If we do the least common case first this will help us for all the remaining data.
| @@ -390,6 +394,10 @@ def fix_header(cls, header, instrument, obsid, filename=None): | |||
| if header[h]: | |||
| header[h] += offset | |||
|
|
|||
| if date > ROTPA_CONVENTION_180_SWITCH1 and date < ROTPA_CONVENTION_180_SWITCH2: | |||
| header['ROTPA'] = header['ROTPA']-180 | |||
There was a problem hiding this comment.
Usually we leave a space around the operator.
mfisherlevine
force-pushed
the
tickets/DM-31997
branch
from
bc5f964
to
b49e8e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.