DM-33942: Support CURINDEX/MAXINDEX/SIMULATE headers for translation #396
Conversation
timj
force-pushed
the
tickets/DM-33942
branch
2 times, most recently
from
0e43b90
to
3c6ef3f
Compare
| @@ -802,3 +802,57 @@ def to_boresight_airmass(self): | |||
| log.warning("%s: Unable to determine airmass of a science observation, returning 1.", | |||
| self._log_prefix) | |||
| return 1.0 | |||
|
|
|||
| @cache_translation | |||
| def to_group_counter_start(self): | |||
There was a problem hiding this comment.
All three of these methods could use a quick docstring.
There was a problem hiding this comment.
Normally the idea is to read the docstring from MetadataTranslator and we try to have docstring inheritance enabled.
| group_counter_end=349, | ||
| group_counter_start=348, |
There was a problem hiding this comment.
This and the next one are the only places where group_counter_end != group_counter_start, and they're only separated by 1. Given that (I think) we are using (or will be using) this to group more than 2 exposures, maybe a test for a wider range would be good? Or am I confusing general groupId stuff with the visit system stuff here?
There was a problem hiding this comment.
You may want to read the ObservationInfo docs. For LSST instruments these are going to record the first sequence number in the visit and the last sequence number in the visit. Robert insists that there will only ever be 2 exposures in a visit. This is a real LATISS header.
"group_counter_start/end" is kept general enough in ObservationInfo that other instruments can decide to use it for whatever counting scheme they want. I did not want to use the term "visit" in the definition. The LSST define-visits code can define visits by using these group_counters or by using the group_id but we are expecting the group_counter version to be the default.
timj
force-pushed
the
tickets/DM-33942
branch
3 times, most recently
from
0e607ea
to
b956458
Compare
So delete override.
Used by lsst/astro_metadata_translator#55