DM-34919: Remove gen2 support #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
parejkoj
reviewed
May 26, 2022
| instrument.makeDefaultRawIngestRunName(), | ||
| instrument.makeCalibrationCollectionName()] | ||
| cls._butler = lsst.daf.butler.Butler(cls.data_dir, collections=collections, | ||
| instrument=instrument.getName()) |
There was a problem hiding this comment.
All of the above is instrument agnostic, so it could go into obs_base:butler_tests.setup_*, I think?
There was a problem hiding this comment.
Only if the obs_base tests are dropping gen2 and we think any of these tests are worth keeping.
|
ccdExposureId is not anything to do with butler so the test is no longer relevant. detector names are all handled transparently by the detector dimension record in butler (which comes from the ObservationInfo) so there is no specialist parsing involved, unlike gen2. The tests asking for a dataset by raft and name_in_raft show that it works. |
The gen2 tests now all fail.
These are small enough that in the future we should consider creating them dynamically. This would prevent us hard-coding a camera geometry into the test but would require an explicit step for the calibration files to ingest them with a dataId and associate them with a validity range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.