Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35524: Change default TS8 filter from NONE to unknown #410

Merged
merged 1 commit into from Jul 9, 2022
Merged

DM-35524: Change default TS8 filter from NONE to unknown #410

merged 1 commit into from Jul 9, 2022

Conversation

timj
Copy link
Member

@timj timj commented Jul 8, 2022

This matches a "valid" TS8 filter definition.

@timj
Change default TS8 filter from NONE to unknown
62fb3b5 
This matches a "valid" TS8 filter definition.
@timj timj requested a review from jchiang87 July 8, 2022 23:59
jchiang87
jchiang87 approved these changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tried this on the TS8 data at issue after setting

TSTAND = 'TS8'
INSTRUME = 'LSST-TS8'

in the PHDU, and the ingest ran fine.

@timj timj merged commit baa0eb2 into main Jul 9, 2022
@timj timj deleted the tickets/DM-35524 branch July 9, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchiang87 jchiang87 jchiang87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @jchiang87