DM-35528: Update TS8 info in obs_lsst for FITS header changes and CCD replacement in slot S00 RTM-004 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
requested changes
Jul 11, 2022
| filename = self._header["FILENAME"] | ||
| self._used_these_cards("FILENAME") | ||
| return filename[:filename.rfind(".")] | ||
| observation_id = self._header["OBSID"] |
There was a problem hiding this comment.
This will break with old TS8 data (there is a reason I didn't use OBSID before) and I don't think it's going to pass the tests. I think you will need to do:
if self._is_key_ok("OBSID"):
observation_id = self._header["OBSID"]
self._used_these_cards("OBSID")
return observation_id
filename = self._header["FILENAME"]
...and leave the old FILENAME code in place.
You likely should add a new TS8 header to the tests/header directory and add a test for it.
timj
approved these changes
Jul 11, 2022
jchiang87
force-pushed
the
tickets/DM-35528
branch
from
eb2b86a
to
d9ffb5b
Compare
timj
approved these changes
Jul 15, 2022
| @@ -242,6 +242,10 @@ def to_exposure_id(self): | |||
| @cache_translation | |||
| def to_observation_id(self): | |||
| # Docstring will be inherited. Property defined in properties.py | |||
| if self.is_key_ok('OBSID'): | |||
There was a problem hiding this comment.
Minor nit: This method is using double quotes everywhere except this line.
jchiang87
force-pushed
the
tickets/DM-35528
branch
from
d9ffb5b
to
f9a90fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.