Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-8889: Add detector z-offsets #416

Merged
merged 2 commits into from Sep 2, 2022
Merged

DM-8889: Add detector z-offsets #416

merged 2 commits into from Sep 2, 2022

Conversation

jmeyers314
Copy link
Contributor

No description provided.

Copy link
Member

@RobertLuptonTheGood RobertLuptonTheGood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

At the risk of attracting complaints about the general lack of docs on yamlCamera, where is it documented that offsets may be specified with 2- or 3- values (with [2] defaulting to 0)?

@jmeyers314
Copy link
Contributor Author

jmeyers314 commented Sep 1, 2022

where is it documented that offsets may be specified with 2- or 3- values (with [2] defaulting to 0)?

Added https://github.com/lsst/obs_lsst/pull/416/files#diff-a66f10959b31a508e4f363ab528d9c3e55f99de92d1c5ce8f14eabe266404d42R37-R39.

(Note that offsets here and elsewhere may
   either be specified as 2-tuples, in which case the z-offset is inferred to be
   0.0, or directly as 3-tuples with their z-offset explicit).

@jmeyers314 jmeyers314 merged commit 5c8a750 into main Sep 2, 2022
@jmeyers314 jmeyers314 deleted the tickets/DM-8889 branch September 2, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants