DM-35902: Remove getAmpImage #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
requested review from
RobertLuptonTheGood
and removed request for
mfisherlevine
There was a problem hiding this comment.
Looks good, given that gen3 addresses this natively.
However, I am worried that there may be client code (e.g. camera team notebooks) that use this API. Should we provide a helper function, or at least a function that says, "Please use butler.get(..., amp=1)" (or whatever the syntax is)?
|
If any existing camera notebooks are using this then those notebooks will be breaking long before they get to this part of the code. They can no longer access a gen2 butler so they can't be at the point where they have anything to pass to this function. I don't think adding a message in this function will ever trigger for existing notebooks. |
Gen2-specific.
timj
force-pushed
the
tickets/DM-35902
branch
from
4b8f514
to
0f03fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gen2-specific.