Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37912: Investigate extendedness criterion for PSF candidate selection in LATISS #443

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

laurenam
Copy link
Contributor

No description provided.

With a few config override settings, the objectSize selector works well
with LATISS data (and these settings recovered half, 12 of 24,  of the
previously failing PSF model attempts in a test dataset).

Some minor updates to the astrometric matcher are also made to help
with cases previously failing to find matches.
@laurenam laurenam requested a review from edennihy March 24, 2023 20:17
Copy link
Contributor

@edennihy edennihy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, approved. There is a minor typo in the comment to address before merging.

config.installSimplePsf.fwhm = 2.355*2 # LATISS platescale is 2x LSST nominal

# Turn off S/N cut for aperture correction measurement source selection
# (it now only includesw calib_psf_used objects, and that cut is "good
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo in comment "includes"

@laurenam laurenam merged commit be6179a into main Mar 24, 2023
@laurenam laurenam deleted the tickets/DM-37912 branch March 24, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants