Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39346: Fixes for LSSTCam and TS8 filter definitions #454

Merged
merged 5 commits into from
May 24, 2023
Merged

DM-39346: Fixes for LSSTCam and TS8 filter definitions #454

merged 5 commits into from
May 24, 2023

Commits on May 24, 2023

  1. update filter definitions for test_filter_defs code 

    include GENERIC_FILTER_DEFINITIONS in __all__
ensure 'empty' isn't prepended for CCOB filter combinations when FILTER keyword is null
include LsstCamFiltersGeneric in imSim filter defs
    @jchiang87
    jchiang87 committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5235503 View commit details
    Browse the repository at this point in the history

  2. add test code for filter definitions

    @jchiang87
    jchiang87 committed May 24, 2023
    Configuration menu
    Copy the full SHA
    530aad9 View commit details
    Browse the repository at this point in the history

  3. remove trailing ~empty from LSSTCam physical_filter values

    @jchiang87
    jchiang87 committed May 24, 2023
    Configuration menu
    Copy the full SHA
    88f0fee View commit details
    Browse the repository at this point in the history

  4. we can simplify here since the subclasses handle the 'empty' and empt… 

    …y string filter keyword values
    @jchiang87
    jchiang87 committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5208c0f View commit details
    Browse the repository at this point in the history

  5. set FILTER to null as in actual TS8 data

    @jchiang87
    jchiang87 committed May 24, 2023
    Configuration menu
    Copy the full SHA
    a1beed1 View commit details
    Browse the repository at this point in the history