DM-38986: Update gain, read noise, saturation values for LSSTCam #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For gain and read noise, use the values from the ptc analysis of run 13412. * For saturation, use the per-amp max of 13339 (acq_run 13144) and 13412 for the maximum_observed_signal and bias levels from 13421 when computing saturation.
plazas
approved these changes
Jul 25, 2023
| @@ -132,15 +131,6 @@ def updateFromEOTest(RXXDir, raftNames, updatedData): | |||
| with open(RXXFile) as fd: | |||
| raftNameData = yaml.load(fd, yaml.CSafeLoader) | |||
|
|
|||
| shutil.copyfile(RXXFile, RXXFile + "~") # make a backup, although we also have git | |||
There was a problem hiding this comment.
It's not necessary to do this back up anymore?
There was a problem hiding this comment.
The unaltered files are already kept track of by git. And if this code is run more than once, as I had to do while understanding that the workaround for corner rafts wasn't needed, the existing backup files get overwritten with altered data, so they're really not useful at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.