DM-40918: Use unified CCS/OCS sequence number for exposure_id #472
Conversation
No longer add 3000 to the year for CCS data when calculating exposure IDs.
| @@ -412,13 +412,20 @@ def compute_exposure_id(dayobs, seqnum, controller=None): | |||
| if seqnum >= 10**_SEQNUM_MAXDIGITS: | |||
| raise ValueError(f"Sequence number ({seqnum}) exceeds limit") | |||
|
|
|||
| dayobs = int(dayobs) | |||
| if dayobs > 20231004 and controller == "C": | |||
There was a problem hiding this comment.
@ktlim this is the line that needs to change when we decide on a date. Ideally this would be in a weekly that can be used by the ingest system (and OODS? cc/ @srp3rd ) before the switch over date. We can instead pick a date in November here, let camera change to unified numbering next week, and just allow a month of data to use the 1000 offset -- there won't be any clashes and it will be fine, just odd looking for people (but it's already odd for people now)
There was a problem hiding this comment.
Might be nice to move the cast up above the seqnum code to where the rest of the dayobs handling is. But the if pertains to controller so should probably stay here.
Yes, the OODS also uses this ingest code. I understand that it can be any weekly (although I think OODS and auto-ingest can use dailies if need be) after the Camera has actually switched, but the fewer images that are taken in between the better. (I suspect that most of the controller-C images taken in between will actually be tests of the system.)
There was a problem hiding this comment.
@tony-johnson is 20231004 a reasonable date for me to pick if I merge by tomorrow (so would be in this weekly)?
| @@ -412,13 +412,20 @@ def compute_exposure_id(dayobs, seqnum, controller=None): | |||
| if seqnum >= 10**_SEQNUM_MAXDIGITS: | |||
| raise ValueError(f"Sequence number ({seqnum}) exceeds limit") | |||
|
|
|||
| dayobs = int(dayobs) | |||
| if dayobs > 20231004 and controller == "C": | |||
There was a problem hiding this comment.
Might be nice to move the cast up above the seqnum code to where the rest of the dayobs handling is. But the if pertains to controller so should probably stay here.
Yes, the OODS also uses this ingest code. I understand that it can be any weekly (although I think OODS and auto-ingest can use dailies if need be) after the Camera has actually switched, but the fewer images that are taken in between the better. (I suspect that most of the controller-C images taken in between will actually be tests of the system.)
Uses a faked header file of a CCS observation from before the switch over made to look like one from the future. It's based off lsstCam-MC_C_20190319_000001_R10_S02.yaml.
timj
force-pushed
the
tickets/DM-40918
branch
from
be57407
to
73afbdb
Compare
No description provided.