DM-42115: Add z, y to fgcmcal LATISS config and fix minimum number of detectors for "good" visits #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Dec 12, 2023
| "z": fgcmcal.Sedterm(primaryTerm="iz", secondaryTerm="zy", constant=1.0), | ||
| "y": fgcmcal.Sedterm(primaryTerm="zy", secondaryTerm="iz", constant=0.25, | ||
| extrapolated=True, primaryBand="y", secondaryBand="z", | ||
| tertiaryBand="i"), |
There was a problem hiding this comment.
Why do some get prim/second/ter/iaryBand entries (just curious)? Is it worth mentioning something about how the constant values are determined?
There was a problem hiding this comment.
The formulae are in the appendix of the FGCM Burke et al paper, and the constants ... well, I should put my scripts somewhere, but they come from eyeballing synthetic loci actually. Things are not super sensitive to these constants (at least in any metrics that we looked at in DES)
erykoff
force-pushed
the
tickets/DM-42115
branch
from
b4d5c25
to
3602c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.