DM-42636: Support the new day_obs and group butler dimensions #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-42636
branch
3 times, most recently
from
1a480fd
to
f002937
Compare
TallJimbo
approved these changes
Feb 20, 2024
timj
force-pushed
the
tickets/DM-42636
branch
5 times, most recently
from
8c7ce12
to
1896df4
Compare
TallJimbo
approved these changes
Feb 28, 2024
timj
force-pushed
the
tickets/DM-42636
branch
from
1896df4
to
8bcc246
Compare
This is a direct copy of the visit_id calculation. The assumption is that the visit_id calculation will be deprecated once we retire all dimension universes that use it as a proxy for group_id during ingest.
The translator already had a ROLLOVER TIME used to calculate observing_day if it was not found in the header but it was not right for lab instruments.
This allows the base translator to calculate the observing day. Need to change some of the dates in tests now that the offset is being included properly.
timj
force-pushed
the
tickets/DM-42636
branch
from
8bcc246
to
7228da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.