DM-42862: initial DRP pipeine for ComCamSim #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yalsayyad
commented
Feb 14, 2024
yalsayyad
commented
- transformObjectCatalog and the
- measurement plugins in MeasureMergedCoaddSourcesTask which apply to all cameras.
This was referenced Feb 14, 2024
- transformObjectCatalog, - objectTableTractAnalysis, and - measurement plugins in MeasureMergedCoaddSourcesTask which apply to all cameras.
yalsayyad
force-pushed
the
tickets/DM-42862
branch
from
8693051
to
cf2016e
Compare
yalsayyad
changed the title
erykoff
reviewed
Feb 15, 2024
There was a problem hiding this comment.
I'm worried that all the coadd measurements will fail because we don't have aperture corrections from characterizeImage.py which either needs to be lifted to the parent (probably bad idea for side effects on latiss) or we create a comcamsim directory (though I don't know the camelCasing to make that work.)
erykoff
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.