Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42513: Scripts to add transmission_optics and transmission_filter data to obs_lsst_data for comCamSim #504

Merged
merged 3 commits into from Feb 24, 2024

Conversation

jchiang87
Copy link
Contributor

No description provided.

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, even without main in the scripts. 😄 . I'll add my comment from obs_lsst_data here that I think it would be worth trimming the filter throughputs to suppress the near-zeros out-of-band which I don't think are physical.

@jchiang87 jchiang87 merged commit 6c5100b into main Feb 24, 2024
3 checks passed
@jchiang87 jchiang87 deleted the tickets/DM-42513 branch February 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants