Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43117: Now use exposure.day_obs in query again. #508

Merged
merged 2 commits into from
Mar 1, 2024
Merged

DM-43117: Now use exposure.day_obs in query again. #508

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
975c0e0
Revert "Support day_obs in query as formal dimension in modern universe"
timj Mar 1, 2024
06c53e2
Some minor docstring fixes
timj Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions python/lsst/obs/lsst/_ingestPhotodiode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,6 @@ def run(self, locations, run=None, file_filter=r"Photodiode_Readings.*txt$|_phot
registry = self.butler.registry
registry.registerDatasetType(self.datasetType)

if "day_obs" in self.butler.dimensions["exposure"].implied:
day_obs_key = "day_obs"
else:
day_obs_key = "exposure.day_obs"

# Find and register run that we will ingest to.
if run is None:
run = self.instrument.makeCollectionName("calib", "photodiode")
Expand Down Expand Up @@ -178,7 +173,7 @@ def run(self, locations, run=None, file_filter=r"Photodiode_Readings.*txt$|_phot
seqNum = calib.getMetadata()['seq_num']

# Find the associated exposure information.
whereClause = f"{day_obs_key}=dayObs and exposure.seq_num=seqNum"
whereClause = "exposure.day_obs=dayObs and exposure.seq_num=seqNum"
instrumentName = self.instrument.getName()
binding = {"dayObs": dayObs, "seqNum": seqNum}
logId = (dayObs, seqNum)
Expand Down