DM-43033: Add fgcmcal configurations for ComCamSim ops rehearsal data #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
approved these changes
Mar 6, 2024
| config.ccdGrayFocalPlaneFitMinCcd = 3 | ||
| config.ccdGrayFocalPlaneChebyshevOrder = 2 | ||
| # Do not model the magnitude errors (use errors as reported). | ||
| config.modelMagErrors = True |
There was a problem hiding this comment.
Shouldn't this be False, based on the comment above?
There was a problem hiding this comment.
Or the comment is copied from a test config where we don't have much coverage. Will fix comment.
erykoff
force-pushed
the
tickets/DM-43033
branch
2 times, most recently
from
43287aa
to
33a0f6e
Compare
erykoff
force-pushed
the
tickets/DM-43033
branch
from
33a0f6e
to
67b4b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.