Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43368: Add TEMP_SET to keywords to check for ISR. #515

Merged
merged 1 commit into from Mar 18, 2024
Merged

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Mar 18, 2024

Add TEMP_SET to keywords to check.

@czwa czwa requested a review from erykoff March 18, 2024 21:01
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all automatically forwarded into the calib headers, right? This is just comparing TEMP_SET which is already in the calib header and warning if it doesn't match?

@czwa
Copy link
Contributor Author

czwa commented Mar 18, 2024

They will be automatically forwarded into the combined calibration header only if they are identical in all input exposures. I don't think this was a decision made with this feature in mind, but rather to ensure there's no ambiguity in the header values that are propagated from the inputs. For this case, either the inputs all agree (and the keyword appears in the calibration header), or they disagree, the keyword is excluded from the combined calibration, and using that calibration for any processing will result in a warning that the calibration does not have the keyword for comparison (and will raise in the future when we make that switch).

@timj
Copy link
Member

timj commented Mar 18, 2024

The header merging scheme can be controlled but at the moment there is no ability to say that headers that differ should be dropped apart from one specific header which should have all values duplicated.

@czwa czwa merged commit ee3fb38 into main Mar 18, 2024
3 checks passed
@czwa czwa deleted the tickets/DM-43368 branch March 18, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants