Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43347: Configure visit-level refcat match analysis tools tasks for ComCamSim #516

Merged
merged 1 commit into from
Mar 21, 2024
Merged

DM-43347: Configure visit-level refcat match analysis tools tasks for ComCamSim #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions config/comCamSim/analysisToolsPhotometricCatalogMatchVisit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
configDir = os.path.dirname(__file__)
config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, 'filterMap.py'))

config.connections.refCatalog = "uw_stars_20240228"
config.referenceCatalogLoader.doApplyColorTerms = False
3 changes: 1 addition & 2 deletions config/comCamSim/refCatSourceAnalysisTask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
"""comCamSim-specific overrides for RefCatSourceAnalysisTask"""

config.connections.refCatalog = "uw_stars_20240228"
config.connections.outputName = "sourceTable_visit_uw_stars_20240228_match"
config.connections.data = "sourceTable_visit_uw_stars_20240228_match"
3 changes: 3 additions & 0 deletions config/comCamSim/refCatSourcePhotometricAnalysisTask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"""comCamSim-specific overrides for RefCatSourcePhotometricAnalysisTask"""

config.connections.data = "sourceTable_visit_uw_stars_20240228_photoMatch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the details here but just to double check, is this supposed to end in _photoMatch or _match? I don't see this datset type in /repo/ops-rehearsal-3-prep.

Copy link
Contributor Author

@yalsayyad yalsayyad Mar 21, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Sophie's ticket in Dec, the astrometry match tasks use the old names and the photometry one adds the word photo or Photometric in front of everything. This is the one I commented on the PR that it doesn't run. Necessary but not sufficient. I was hoping to get some help from @sr525 during pair coding today. Maybe someone else can get it going in the next week