DM-43436: Enable OBJECT and AZEL translations for LSSTCam #517
Conversation
Phosim comcam observations seem to be missing AZSTART so that has to be skipped.
This is currently problematic because the simulated files use a DATE-BEG that differs from the date used to calculate the airmass and hour angle. It's not clear what the right thing to do is for azel calculation since calculating the actual values for the DATE-BEG might end up with a negative elevation. Trying to calculate the azimuth from the hour angle / declination / airmass would lead to an azimuth that is not consistent with the time and ra/dec.
Default to UNKNOWN.
Must disable WCS checks because AltAz is inconsistent.
|
It has been suggested on Slack that I also add header fixup code for comcamsim to copy RA/DEC into [RA|DEC][START|END} since they must be identical in simulated data like this. This doesn't solve the AZEL problem but does mean that downstream of ISR the header will be filled in. |
| controller = self._header[ctrlr_key] | ||
| self._used_these_cards(ctrlr_key) | ||
| controller = self._get_controller_code() | ||
| if controller: | ||
| if controller in "HPQ": |
There was a problem hiding this comment.
Should this test also include controller "S"?
There was a problem hiding this comment.
@jchiang87 I fixed this but I also added some header fixups for things like RASTART/RAEND and fixed an age-old ComCam translator bug from #167. It's quite a lot of code so I've asked for a re-review.
The fix from DM-23310 (6325206) was incorrect since it was checking for a telescope match when it should have been checking for a "LSST_CAMERA" instrument name. This meant that the ComCam translator was saying it could translate ComCamSim headers. Also removed the broken check from ComCamSim since two instruments can't be using identical (and in this case incorrect) heuristics for determining whether they can translate the header.
|
I will fix the problem with the day_obs offset calculation on another ticket. It's not important for ops rehearsal since we are not yet using butler universe version 6 for that. |
ComCamSim needs special code because the AZEL values are missing and airmass is inconsistent with the observation date.