Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42747: Fiducial values for summary stats for comCamSim #518

Merged
merged 1 commit into from Mar 26, 2024

Conversation

kadrlica
Copy link
Contributor

Adds fiducial values of seeing, sky brightness, and zeropoints for comCamSim in preparation for processing of Ops Rehearsal 3. Note: fiducials are not set for the characterizeImage task, since there is no comCamSim-specific config for this task.

@laurenam
Copy link
Contributor

Note: fiducials are not set for the characterizeImage task, since there is no comCamSim-specific config for this task.

...is not a reason to skip adding a needed config override (i.e. you would need to add the file). But in this case, this:
https://github.com/lsst/pipe_tasks/blob/main/python/lsst/pipe/tasks/characterizeImage.py#L173-L185
is a good reason not to include it 😉

@kadrlica
Copy link
Contributor Author

Yeah, that is a much better reason :).

Here is the successful Jenkins run 972.

@jrmullaney
Copy link

This looks fine to me. Just a minor thing...I suggest you expand a little on the "Plots can be found in DM-42747" comment. Perhaps "Plots, including the median values used here, can be found on JIRA ticket DM-42747"? It'll need a rebase before merging as well.

Happy to sign-off on this - no need to re-request.

@kadrlica kadrlica merged commit 04e5ce7 into main Mar 26, 2024
3 checks passed
@kadrlica kadrlica deleted the tickets/DM-42747 branch March 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants