DM-43495: Fix observing day offset for ComCamSim and LSSTCamSim #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify translator tests to test for that offset.
Neither native ComCamSim or LSSTCamSim files use the correct definition of observing day. This meant that now that we are testing for conformance they failed the tests. Use a ComCamSim file from OR3 that was generated from the test stand (and so does conform). This file was also zeroed out to take up less space. There are no conformant LSSTCamSim files at this time so the file was rewritten with an MJD-OBS that does match the day obs. It is not posible to use the controller code when calculating the observing day offset.
jchiang87
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also test for the offset. This required some file modifications for the simulated LSSTCamSim since it was not conformant. An OR3 ComCamSim file is used now.