DM-17530: Add support for BNL TS3 data #70
Conversation
timj
force-pushed
the
tickets/DM-17530
branch
from
c10b5b8
to
14491f6
Compare
timj
force-pushed
the
tickets/DM-17530
branch
from
14491f6
to
8a12985
Compare
Each detector is assigned a single raft. 435 detectors are defined includeing ITL and E2V. The amplifier definitions are a clone of TS8.
|
@mfisherlevine take a look at this and see what you think. I can ingest those two TS3 files now without a problem. I need to add nulled out versions to the local obs_lsst butler repo so I can run the tests. |
|
OK, looks good. Thanks Tim! |
timj
force-pushed
the
tickets/DM-17530
branch
from
e738b1c
to
eaf23c1
Compare
timj
force-pushed
the
tickets/DM-17530
branch
from
eaf23c1
to
6f905fd
Compare
| _DETECTOR_NAME = "S00" | ||
|
|
||
|
|
||
| class LsstTS3Translator(StubTranslator): | ||
| class LsstTS3Translator(LsstSimTranslator): |
There was a problem hiding this comment.
Hmmm, that's an interesting change. I'm sure it makes sense, but important from the Sims translator rather than something that sounds like some sort of base class is surprising.
There was a problem hiding this comment.
It's telling you that imsim and phosim share infrastructure that is also now needed by TS3 (and TS8 it turns out) and that at this point the parent class name is wrong.
| exptimes = {'raw': 30.611} | ||
| detectorIds = {'raw': 71} | ||
| detector_names = {'raw': 'R071_S00'} | ||
| detector_serials = {'raw': 'ITL-3800C-098'} |
There was a problem hiding this comment.
Nice choice of chips. Is that a coincidence, or was that deliberate?
There was a problem hiding this comment.
You chose them (this is zeroed out data from the testdata repository).
Also document how the TS3 data was created.
timj
force-pushed
the
tickets/DM-17530
branch
from
6f905fd
to
2b71fbf
Compare
@mfisherlevine should we use the #66 approach of having R00 be E2V data and R01 be ITL data? Do you have a list of all the detector serial numbers to be supported? Do we have a raft per sensor to make the camera yaml easier?