Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-17292: Improve test coverage #74

Merged
merged 23 commits into from
Feb 5, 2019
Merged

DM-17292: Improve test coverage #74

merged 23 commits into from
Feb 5, 2019

Conversation

timj
Copy link
Member

@timj timj commented Jan 31, 2019

Significantly improve test coverage, especially in the mappers.

SimonKrughoff
SimonKrughoff approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the great cleanups!

python/lsst/obs/lsst/ingest.py Show resolved Hide resolved
python/lsst/obs/lsst/auxTel.py Show resolved Hide resolved
python/lsst/obs/lsst/lsstCamMapper.py Outdated Show resolved Hide resolved
python/lsst/obs/lsst/ts8.py Show resolved Hide resolved
tests/test_auxTel.py Outdated Show resolved Hide resolved
tests/test_parsetask.py Show resolved Hide resolved
tests/test_phosim.py Outdated Show resolved Hide resolved
tests/test_ts8.py Show resolved Hide resolved
tests/test_ucdcam.py Outdated Show resolved Hide resolved
@timj
Specify raw filename in way consistent with other tests
519d8d8
@timj
Fix VisitInfo constructor in raw_visitInfo method
085007b 
Can not use the constructor directly, but must go through
the specialist VisitInfo construction class.
@timj
Add check to make sure test class is configured properly
dea76be
@timj
Add new test methods for checking filename and visitInfo butler usage
cab5b57
@timj
Add tests for coaddIds
c9ca0df
@timj
Add more checks for consistent detector group and name values
213ee52
@timj
Add tests got CcdExposureId calculation
734e3b0
@timj
No longer need to instantiate a Camera in ParseTask
d6bb773 
None of the gen2 translate methods use it directly.
@timj
Factor out code for constructing a ParseTask in tests
74f0c29
@timj
Add explicit test for SEQNUM missing from header in auxTel
be5ca83
@timj
Test the AuxTel translate_seqNum method and refactor it a bit
374ebcd
@timj
Remove getInfo subclass since we never use the basename field
2a1b8a5
@timj
Add test for non-integer wavelength
e5bd2fe
@timj
Replace afwGeom with lsst.geom where appropriate
a355dc2
@timj
Add explicit test for ts8 translate_testSeqNum
8a9c7da
@timj
Raise ValueError rather than IndexError for consistency
1e26419
@timj
Add tests for detector name
fcbd120
@timj
Now that code coverage is high remove the empty import test
db1385b
@timj
Remove code that is masked by "if False"
0d5481e
@timj
Add tests for queryRawAmp
52b48ed
@timj
Fixes from review
e7fb0c5
@timj
Use bin.src variant since the bin/ variant may not exist yet
496bc83
@timj timj merged commit 559fa2a into master Feb 5, 2019
@timj timj deleted the tickets/DM-17292 branch February 5, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonKrughoff SimonKrughoff SimonKrughoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @SimonKrughoff